This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia][scenic] Reset the state of a PointerInjectorEndpoint on channel closure#35241
Merged
shivesh-ganju merged 1 commit intoflutter:mainfrom Aug 10, 2022
Merged
Conversation
arbreng
approved these changes
Aug 8, 2022
jaeheon
reviewed
Aug 9, 2022
| injection_in_flight_ = false; | ||
| registered_ = false; | ||
| std::queue<std::vector<fuchsia::ui::pointerinjector::Event>> empty; | ||
| std::swap(injector_events_, empty); |
Contributor
There was a problem hiding this comment.
might be simpler to say
injector_events_ = {};
channel closure. This CL resets the state including cleaning up the buffers whenever a fuchsia.ui.pointerinjector.Device channel closes due to some error. Test: flutter_runner_tests
9d8b976 to
624e92b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
…utter#35241) channel closure. This CL resets the state including cleaning up the buffers whenever a fuchsia.ui.pointerinjector.Device channel closes due to some error. Test: flutter_runner_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL resets the state including cleaning up the buffers whenever
a fuchsia.ui.pointerinjector.Device channel closes due to some error.
Test: flutter_runner_tests