This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add tile modes to gaussian blur#35249
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Aug 9, 2022
Merged
[Impeller] Add tile modes to gaussian blur#35249auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
chinmaygarde
approved these changes
Aug 9, 2022
Contributor
Author
|
This also fixes the problem where backdrop filters have a dark halo around them (since they use kClamp, but we were always behaving like kDecal prior to this change). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#105072.
Screen.Recording.2022-08-08.at.4.48.38.PM.mov
Currently, this only works for transforms whose basis vectors align with their axis (no rotations/skews) because of how the blur rendering currently works. This will get naturally fixed in a future optimizing refactor I'm planning that will allow filters full control over how/if new textures are created.