This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add FLUTTER_DEPRECATED macro and flutter_macros.h#35293
Merged
cbracken merged 1 commit intoflutter:mainfrom Aug 10, 2022
cbracken:add-macros-header
Merged
Add FLUTTER_DEPRECATED macro and flutter_macros.h#35293cbracken merged 1 commit intoflutter:mainfrom cbracken:add-macros-header
cbracken merged 1 commit intoflutter:mainfrom
cbracken:add-macros-header
Conversation
Adds a new header, flutter_macros.h which includes a FLUTTER_DEPRECATED macro that can be used to mark deprecated API as such, with a hopefully-informative message, ideally describing the expected removal version and any migration tips. This will need to be #included in flutter_windows.h and flutter_linux.h, but prior to doing so, we'll need to update the engine recipe to bundle the new header, here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py#1457
8 tasks
yaakovschectman
approved these changes
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Adds a new header, flutter_macros.h which includes a FLUTTER_DEPRECATED macro that can be used to mark deprecated API as such, with a hopefully-informative message, ideally describing the expected removal version and any migration tips. This will need to be #included in flutter_windows.h and flutter_linux.h, but prior to doing so, we'll need to update the engine recipe to bundle the new header, here: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py#1457 No tests since this adds a compiler macro that will be used for future C/C++ API deprecation once the above recipe change has landed; specifically: FlutterDesktopEngineProcessMessages. Related: flutter/flutter#93537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new header, flutter_macros.h which includes a FLUTTER_DEPRECATED
macro that can be used to mark deprecated API as such, with a
hopefully-informative message, ideally describing the expected removal
version and any migration tips.
This will need to be #included in flutter_windows.h and flutter_linux.h,
but prior to doing so, we'll need to update the engine recipe to bundle
the new header, here:
https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py#1457
No tests since this adds a compiler macro that will be used for future
C/C++ API deprecation once the above recipe change has landed;
specifically:
FlutterDesktopEngineProcessMessages.Related: flutter/flutter#93537
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.