This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] Add 'ColorSourceProc' for creating color source contents#35299
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Aug 11, 2022
Merged
[impeller] Add 'ColorSourceProc' for creating color source contents#35299auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
bdero
approved these changes
Aug 11, 2022
Contributor
bdero
left a comment
There was a problem hiding this comment.
LGTM! Just one comment about copy avoidance in a few places.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, use the same paint with a linear gradient to draw a Rect and a Circle, two Circles will appear on the screen.
fix flutter/flutter#109293
test
before change
after change
Pre-launch Checklist
writing and running engine tests.
///).