This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Replace memset with C++ alternatives#35312
Merged
cbracken merged 1 commit intoflutter:mainfrom Aug 10, 2022
cbracken:bye-bye-mon-memset
Merged
[Windows] Replace memset with C++ alternatives#35312cbracken merged 1 commit intoflutter:mainfrom cbracken:bye-bye-mon-memset
cbracken merged 1 commit intoflutter:mainfrom
cbracken:bye-bye-mon-memset
Conversation
Eliminate a few uses of memset in the code, replacing them with C++ alternatives, like using initialiser list syntax and std::array + fill. This avoids some double-hardcoding of array length in the code.
cbracken
requested review from
a-wallen,
dkwingsmt,
loic-sharma and
yaakovschectman
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Eliminate a few uses of memset in the code, replacing them with C++ alternatives, like using initialiser list syntax and std::array + fill. This avoids some double-hardcoding of array length in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate a few uses of memset in the code, replacing them with C++
alternatives, like using initialiser list syntax and std::array + fill.
This avoids some double-hardcoding of array length in the code.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.