This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for relative paths in mac os gen_snapshot.#35324
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Aug 11, 2022
godofredoc:support_relpath_macos
Merged
Add support for relative paths in mac os gen_snapshot.#35324auto-submit[bot] merged 1 commit intoflutter:mainfrom godofredoc:support_relpath_macos
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:support_relpath_macos
Conversation
Relative paths are required for engine v2 builds where we don't know the full path in advance. This is also deleting armv7 code which is not supported anymore. Bug: flutter/flutter#81855
chinmaygarde
approved these changes
Aug 10, 2022
godofredoc
added
the
autosubmit
Contributor
|
This broke local builds. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2022
8 tasks
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative paths are required for engine v2 builds where we don't know the
full path in advance.
This is also deleting armv7 code which is not supported anymore.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.