Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Add support for relative paths in mac os gen_snapshot."#35331

Merged
auto-submit[bot] merged 1 commit intomainfrom
revert-35324-support_relpath_macos
Aug 11, 2022
Merged

Revert "Add support for relative paths in mac os gen_snapshot."#35331
auto-submit[bot] merged 1 commit intomainfrom
revert-35324-support_relpath_macos

Conversation

@flar
Copy link
Contributor

@flar flar commented Aug 11, 2022 •
edited
Loading

Reverts #35324

These errors are now generated on local builds:

FAILED: clang_arm64/gen_snapshot_armv7 
vpython3 ../../flutter/sky/tools/create_macos_gen_snapshots.py --dst /Users/jimgraham/Development/engine/src/out/android_profile/clang_arm64 --clang-dir clang_arm64 --armv7-out-dir /Users/jimgraham/Development/engine/src/out/android_profile
usage: create_macos_gen_snapshots.py [-h] --dst DST [--clang-dir CLANG_DIR]
                                     [--x64-out-dir X64_OUT_DIR]
                                     [--arm64-out-dir ARM64_OUT_DIR]
create_macos_gen_snapshots.py: error: unrecognized arguments: --armv7-out-dir /Users/jimgraham/Development/engine/src/out/android_profile

That tool is called in more than one way, other calling sequences, some of which do not think that armv7 is obsolete, must be updated for this to work.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2022
@auto-submit auto-submit bot merged commit c9a31b7 into main Aug 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2022
@engine-flutter-autoroll
c9a31b7 Revert "Add support for relative paths in mac os gen_snapshot…
10a2599 
…." (flutter/engine#35331)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@flar @emilyabest
Revert "Add support for relative paths in mac os gen_snapshot." (flut…
5144346 
…ter#35331)
@kevmoo kevmoo deleted the revert-35324-support_relpath_macos branch December 2, 2022 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @godofredoc