This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland Add support for relative paths in mac os gen_snapshot.#35332
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Aug 11, 2022
godofredoc:reland_macos_change
Merged
Reland Add support for relative paths in mac os gen_snapshot.#35332auto-submit[bot] merged 1 commit intoflutter:mainfrom godofredoc:reland_macos_change
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:reland_macos_change
Conversation
Relative paths are required for engine v2 builds where we don't know the full path in advance. Armv7 flags were added back to prevent local builds from failing. Bug: flutter/flutter#81855
Contributor
Author
|
This is relanding #35324 but keeping armv7 support. |
flar
approved these changes
Aug 11, 2022
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
I tested local profile host/android/ios builds and they all worked.
Contributor
|
Also tested debug and release builds |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative paths are required for engine v2 builds where we don't know the
full path in advance.
Armv7 flags were added back to prevent local builds from failing.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.