Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use kPremul_SkAlphaType in Picture.toImageSync#35336

Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom
jonahwilliams:fix_color_type
Aug 11, 2022
Merged

Use kPremul_SkAlphaType in Picture.toImageSync#35336
auto-submit[bot] merged 5 commits intoflutter:mainfrom
jonahwilliams:fix_color_type

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Aug 11, 2022

Fixes flutter/flutter#109372

The alpha type was not consistent with regular toImage and resulted in scenes visibility changing when we attempted to roll vector graphics in googlr3

@jonahwilliams jonahwilliams changed the title add golden test of pixel contents Use kPremul_SkAlphaType in Picture.toImageSync Aug 11, 2022
@jonahwilliams jonahwilliams marked this pull request as ready for review August 11, 2022 06:48
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2022
@auto-submit auto-submit bot merged commit 2230e89 into flutter:main Aug 11, 2022
@jonahwilliams jonahwilliams deleted the fix_color_type branch August 11, 2022 23:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toImageSync should use kPremul_SkAlphaType

2 participants