add missing break statements in makeWithLocalMatrix#35346
add missing break statements in makeWithLocalMatrix#35346auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
Are there any blockers to add the clang check as well?
Blockers? While such checks would have caught this, I don't consider their absence an immediate blocker - more like a good preventative idea. |
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
LGTM to unblock the internal rolls.
We should follow up adding the clang check to prevent future breakages from landing.
CaseyHillers
added
the
autosubmit
|
2 participants
These were missed in the original code review, but by luck the missing break statements wouldn't actually cause an issue because the code just works without them anyway. No tests because there is no change in behavior when you add the break statements so there is no programmatic way to know if they are present or missing.