This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Passes and command buffers hold weak handles to the context.#35352
Merged
chinmaygarde merged 1 commit intoflutter:mainfrom Aug 11, 2022
Merged
[Impeller] Passes and command buffers hold weak handles to the context.#35352chinmaygarde merged 1 commit intoflutter:mainfrom
chinmaygarde merged 1 commit intoflutter:mainfrom
Conversation
This makes the submission simpler as the allocators can be acquired from the pass itself. Also makes command buffer submission go through a common method that performs error checking before dispatch to the backend.
Contributor
Author
|
This and the next few patches are API cleanups on the way to landing the multi-threaded encoding stuff. But these cleanups are unrelated. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the submission simpler as the allocators can be acquired from the
pass itself.
Also makes command buffer submission go through a common method that performs
error checking before dispatch to the backend.