[Impeller] [vulkan] Add support for wrapped surfaces#35359
[Impeller] [vulkan] Add support for wrapped surfaces#35359auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
moves the ownership of the surface to ContextVK
|
|
||
| struct TextureInfoVK { | ||
| TextureBackingTypeVK backing_type; | ||
| union { |
There was a problem hiding this comment.
std::variant instead?
There was a problem hiding this comment.
👍🏽 will move to wrapped texture as a new subclass in a follow-up PR.
| // |Texture| | ||
| ~TextureVK() override; | ||
|
|
||
| bool IsWrapped() const; |
There was a problem hiding this comment.
Another thought (for later) could be to just use a different subclass for a wrapped and owned texture.
iskakaushik
added
the
autosubmit
2 participants
No description provided.