This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Cleanup the build dependency graph.#35360
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Aug 12, 2022
Merged
[Impeller] Cleanup the build dependency graph.#35360auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
This was a recent observation that slowed down local development on Impeller. Making small changes to //impeller/renderer and re-building would seemingly build all Impeller related targets (~650 actions). Even with Goma, this was getting annoying. Turns out that //impeller/compiler was including //impeller/runtime_stage that pulled in //impeller/renderer. It did so only for a couple of headers. The downside of this dependency is that a compiler invalidation rebuilds all shaders and also the targets containing the generated C++ headers with shader metadata. This causes the huge number of actions invocations. Another downside is that the compiler was pulling in the renderer making it larger and taking longer to link. Hilariously, it also pulled in Skia because of the SkParagraph shaper used for text layout. This patch reworks the dependency so that runtime stage enums are separate and inverts the runtime_stage dependency on the compiler and renderer. Now, editing and invalidating a //impeller/renderer or related target only invokes < 5 actions instead of the ~650 earlier.
Contributor
Author
|
A no-op build will still build a few files today. But that is being tackled by @jonahwilliams in flutter/flutter#109257 |
bdero
approved these changes
Aug 11, 2022
Contributor
|
Contributor
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2022
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a recent observation that slowed down local development on Impeller.
Making small changes to
//impeller/rendererand re-building would seeminglybuild all Impeller related targets (~650 actions). Even with Goma, this was
getting annoying. Turns out that
//impeller/compilerwas including//impeller/runtime_stagethat pulled in//impeller/renderer. It did so only fora couple of headers.
The downside of this dependency is that a compiler invalidation rebuilds all
shaders and also the targets containing the generated C++ headers with shader
metadata. This causes the huge number of actions invocations.
Another downside is that the compiler was pulling in the renderer making it
larger and taking longer to link. Hilariously, it also pulled in Skia because of
the SkParagraph shaper used for text layout.
This patch reworks the dependency so that runtime stage enums are separate and
inverts the runtime_stage dependency on the compiler and renderer.
Now, editing and invalidating a
//impeller/rendereror related target onlyinvokes < 5 actions instead of the ~650 earlier.