This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Trivial nullptr de-reference fix#35361
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Aug 12, 2022
Merged
[Impeller] Trivial nullptr de-reference fix#35361auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
bdero
approved these changes
Aug 11, 2022
Contributor
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just a suggestion about adding more specific error messages.
impeller/entity/entity_pass.cc
Outdated
| auto pass = pass_context.GetRenderPass(pass_depth); | ||
|
|
||
| if (!pass) { | ||
| FML_DCHECK(false) << "No pass found at depth: " << pass_depth; |
Contributor
There was a problem hiding this comment.
Could you drop the error here and place more specific errors in the InlinePassContext itself? There are 2 situations where this can happen. The first is if the command buffer creation failed and the second is if the RenderPass itself couldn't be created.
iskakaushik
force-pushed
the
fix-npe-entity-pass
branch
from
1f2a766 to
580afc4
Compare
iskakaushik
added
the
autosubmit
| if (!IsActive()) { | ||
| command_buffer_ = context_->CreateCommandBuffer(); | ||
| if (!command_buffer_) { | ||
| FML_DLOG(ERROR) << "Could not create command buffer."; |
Contributor
There was a problem hiding this comment.
We use VALIDATION_LOG for such logging purposes.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.