Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds artifacts to mac_ios release.#35366

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:add_mac_ios_release
Aug 16, 2022
Merged

Adds artifacts to mac_ios release.#35366
auto-submit[bot] merged 2 commits intoflutter:mainfrom
godofredoc:add_mac_ios_release

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Aug 12, 2022

This change generates and uploads the framework sdk and dsym files for
mac_ios_release.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Adds artifacts to mac_ios release.
478fe99 
This change generates and uploads the framework sdk and dsym files for
mac_ios_release.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested a review from XilaiZhang August 12, 2022 02:43
XilaiZhang
XilaiZhang approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Aug 12, 2022

shall we merge this one in case it get forgotten?

@godofredoc
Copy link
Contributor Author

godofredoc commented Aug 12, 2022

shall we merge this one in case it get forgotten?

We need to land another change to engine first.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2022
@auto-submit auto-submit bot merged commit 43cb313 into flutter:main Aug 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
43cb313 Adds artifacts to mac_ios release. (flutter/engine#35366)
34b91fa
@godofredoc godofredoc deleted the add_mac_ios_release branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @XilaiZhang