[Linux][FlView] guard against disconnecting a disconnected signal#35490
[Linux][FlView] guard against disconnecting a disconnected signal#35490dkwingsmt merged 1 commit intoflutter:mainfrom
Conversation
GObject's dispose() method may be called multiple times. Guard against trying to disconnect the same signal multiple times by clearing the ID to avoid warnings when closing the window. ``` (bug:74019): GLib-GObject-WARNING **: 11:15:08.697: ../../../gobject/gsignal.c:2731: instance '0x55e1c3ea0200' has no handler with id '255' ```
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The change LGTM, but is there a way to test it? |
|
I've asked for a test exemption because we cannot create FlView or any GtkWidget instances in the headless CI. |
One option could be to a) run |
|
Can we land this now? Perhaps file a followup for the test? |
4 participants
GObject's dispose() method may be called multiple times.
Guard FlView against trying to disconnect the same signal multiple times by clearing the ID to avoid warnings when closing the window.