This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Set Platform.executable on engine start#35560
Merged
cbracken merged 1 commit intoflutter:mainfrom Aug 20, 2022
cbracken:set-exe-name
Merged
[Windows] Set Platform.executable on engine start#35560cbracken merged 1 commit intoflutter:mainfrom cbracken:set-exe-name
cbracken merged 1 commit intoflutter:mainfrom
cbracken:set-exe-name
Conversation
loic-sharma
approved these changes
Aug 20, 2022
When setting FlutterProjectArgs.command_line_argv prior to launching the engine, we were previously setting a placeholder value rather than the executable name. This resulted in Platform.executable (from dart:io) returning "placeholder" in application code. This updates the Windows implementation for consistency with macOS and guarantees that Platform.executable will return a reasonable value in Dart code. Note that this does not affect Platform.resolvedExecutable, which returns a full, resolved path, and is implemented in the Dart runtime itself. Previously the code: print(Platform.executable); print(Platform.resolvedExecutable); resulted in the following output on Windows: flutter: placeholder flutter: C:\path\to\project\build\windows\runner\Debug\project.exe after this patch, it results in: flutter: project.exe flutter: C:\path\to\project\build\windows\runner\Debug\project.exe Issue: flutter/flutter#83921 Issue: flutter/flutter#83921
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting
FlutterProjectArgs.command_line_argvprior to launching theengine, we were previously setting a placeholder value rather than the
executable name. This resulted in
Platform.executable(from dart:io)returning "placeholder" in application code.
This updates the Windows implementation for consistency with macOS and
guarantees that Platform.executable will return a reasonable value in
Dart code.
Note that this does not affect
Platform.resolvedExecutable, which returnsa full, resolved path, and is implemented in the Dart runtime itself.
Previously the code:
resulted in the following output on Windows:
after this patch, it results in:
Issue: flutter/flutter#83921
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.