Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adjust rules for analyze_snapshot#35585

Merged
zanderso merged 1 commit intoflutter:mainfrom
zanderso:archive-analyze-snapshot
Aug 22, 2022
Merged

Adjust rules for analyze_snapshot#35585
zanderso merged 1 commit intoflutter:mainfrom
zanderso:archive-analyze-snapshot

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Aug 21, 2022 •
edited
Loading

The analyze_snapshot binary is only needed for Linux hosts when targeting x64 Android. This PR narrows down #35495 and adds archive rules that mirror those for gen_snapshot.

Needed for https://flutter-review.googlesource.com/c/recipes/+/32780

@zanderso zanderso requested a review from godofredoc August 21, 2022 15:37
@zanderso
Copy link
Member Author

zanderso commented Aug 21, 2022

cc @perks

@perks
Copy link
Contributor

perks commented Aug 21, 2022 •
edited
Loading

Hey @zanderso thank you for this!

Just wanted to confirm and clarify on my part, would also need arm64/aarch64 android support on the target OS ( I think this might be an additional type besides x64 target_cpu. It also worth noting that it should also work on non-android targets, as long as the snapshot is an AOT precompiled snapshot and is 64 bit, either x64 or arm64 in this case

Edit: to clarify as well, since the tool works by insantiating a bare-bones VM to deserialize the snapshot, for most use cases it is run using qemu on an aarch64 binary

@zanderso zanderso force-pushed the archive-analyze-snapshot branch from 42b4f07 to 0f672d2 Compare August 22, 2022 17:26
@zanderso
Copy link
Member Author

zanderso commented Aug 22, 2022

Changed to build for more platforms.

@zanderso zanderso merged commit 75d7843 into flutter:main Aug 22, 2022
@zanderso zanderso deleted the archive-analyze-snapshot branch August 22, 2022 18:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 22, 2022
@engine-flutter-autoroll
75d7843 Adjust rules for analyze_snapshot (flutter/engine#35585)
c7046f6
@zanderso
Copy link
Member Author

zanderso commented Aug 22, 2022

@perks https://flutter-review.googlesource.com/c/recipes/+/32780 will start uploading the tool for 64-bit Android targets. Let's start out with that. Given our current build setup, the tool for analyzing 64-bit iOS targets would only be able to run on macOS.

@perks
Copy link
Contributor

perks commented Aug 22, 2022

@zanderso Sounds great, thank you so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @perks @godofredoc