This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[lint] Update local variable names in display_list#36097
Merged
cbracken merged 1 commit intoflutter:mainfrom Sep 13, 2022
cbracken:fix-locals-display-list
Merged
[lint] Update local variable names in display_list#36097cbracken merged 1 commit intoflutter:mainfrom cbracken:fix-locals-display-list
cbracken merged 1 commit intoflutter:mainfrom
cbracken:fix-locals-display-list
Conversation
chinmaygarde
approved these changes
Sep 12, 2022
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Nice! You automated this using something like clang-tidy right? cc @flar
Member
Author
|
Not quite fully automated since a lot of the name suggestions were 'weird', but yeah automated then hand-tweaked. Will find somewhere in the wiki to document how to add/apply new lints if we don't have it already. |
Member
Author
|
Doing it piecewise in chunks at the directory level due to the manual review/tweaking of names. Once locals are done, I'll find some time to do method/function parameters. (Mostly, I was just bored this weekend) |
loic-sharma
reviewed
Sep 12, 2022
This updates local variable names to use clang `lower_case` style in the display_list directory. This is one of several patches to update our variable names to a consistent style before enabling enforcement in our clang-tidy rules. This is a formatting-only change with no intended semantic change.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
This updates local variable names to use clang `lower_case` style in the display_list directory. This is one of several patches to update our variable names to a consistent style before enabling enforcement in our clang-tidy rules. This is a formatting-only change with no intended semantic change.
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
This updates local variable names to use clang `lower_case` style in the display_list directory. This is one of several patches to update our variable names to a consistent style before enabling enforcement in our clang-tidy rules. This is a formatting-only change with no intended semantic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates local variable names to use clang
lower_casestyle in the display_list directory. This is one of several patches to update our variable names to a consistent style before enabling enforcement in our clang-tidy rules.This is a formatting-only change with no intended semantic change.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.