Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Make 'DrawPaint' support color sources#36115

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
ColdPaleLight:draw_paint_with_color_source
Sep 14, 2022
Merged

[Impeller] Make 'DrawPaint' support color sources#36115
auto-submit[bot] merged 1 commit intoflutter:mainfrom
ColdPaleLight:draw_paint_with_color_source

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Sep 13, 2022 •
edited
Loading

fix flutter/flutter#111314
NxdliNAOFJ

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight self-assigned this Sep 13, 2022
dnfield
dnfield reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me but I'd appreciate a review from @bdero since I think he had some ideas about this

bdero
bdero approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2022
@auto-submit auto-submit bot merged commit a1f978a into flutter:main Sep 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
a1f978a [Impeller] Make 'DrawPaint' support color sources (flutter/en…
f3ee5a2 
…gine#36115)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@ColdPaleLight
[Impeller] Make 'DrawPaint' support color sources (flutter#36115)
1e41438
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dnfield dnfield dnfield left review comments

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ColdPaleLight ColdPaleLight

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] canvas.drawPaint does not handle gradients

3 participants

@ColdPaleLight @bdero @dnfield