Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Separate GitHub workflow jobs#36127

Merged
sealesj merged 12 commits intoflutter:mainfrom
sealesj:separate-github-workflow-jobs
Sep 14, 2022
Merged

Separate GitHub workflow jobs#36127
sealesj merged 12 commits intoflutter:mainfrom
sealesj:separate-github-workflow-jobs

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented Sep 13, 2022

Create prerequisite job for python setup and deps_parser in order to avoid having custom/unsupported actions in the same job as the scorecards_analysis

In order to make the setup job a prerequisite, I used the keyword "needs" for the scorecards job and then linked the setup job

Context: ossf/scorecard-action#910

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@drewroengoogle drewroengoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with question

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 13, 2022

auto label is removed for flutter/engine, pr: 36127, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@sealesj sealesj merged commit e4cb9d4 into flutter:main Sep 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
* boringssl metadata for vuln scan

* update date, add owners test

* move unsupported actions into new job

* temp remove branch protection for test

* minor change

* fake change

* no branch check

* re-enable branch protection

* updates

* refactor further into generic setup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants