This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[lint] Enforce kCamelCase for global constants#36175
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Sep 15, 2022
cbracken:const-lint
Merged
[lint] Enforce kCamelCase for global constants#36175auto-submit[bot] merged 1 commit intoflutter:mainfrom cbracken:const-lint
auto-submit[bot] merged 1 commit intoflutter:mainfrom
cbracken:const-lint
Conversation
This updates global constants to use clang `CamelCase` style and enforce this in a lint. This is a formatting-only change with no intended semantic change.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change |
chinmaygarde
approved these changes
Sep 15, 2022
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 15, 2022
* 06fe761 [Impeller] Make gradients work as expected (flutter/engine#36140) * f18d17b Roll Skia from 962fd1f9abfc to 6e0e0a9f6cbf (3 revisions) (flutter/engine#36174) * 5e6b0d8 Enable dart null-safety (flutter/engine#36154) * ccba311 Fix typo (flutter/engine#36167) * b828d30 [lint] Enforce kCamelCase for global constants (flutter/engine#36175) * 9a6caba Roll Skia from 6e0e0a9f6cbf to 7c2dc625d01e (2 revisions) (flutter/engine#36178)
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates global constants to use clang
CamelCasestyle and enforce this in a lint.This is a formatting-only change with no intended semantic change.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.