Warn if we have not built CanvasKit and requested --use-local-canvaskit#36211
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
| if (useLocalCanvasKit && !builtLocalCanvasKit) { | ||
| print('WARNING: Requested to use local CanvasKit but could not find the ' | ||
| 'built CanvasKit at ${localCanvasKitWasm.path}. Falling back to ' | ||
| 'CanvasKit from CIPD.'); |
There was a problem hiding this comment.
Let's throw. Otherwise, this can silently switch on CI or something and lead to surprises.
2 participants
This is to give extra confidence that we are actually testing against the locally built CanvasKit on LUCI.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.