This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix corner case errors in platform channels#3631
Merged
mravn-google merged 4 commits intoflutter:masterfrom Apr 27, 2017
Merged
Fix corner case errors in platform channels#3631mravn-google merged 4 commits intoflutter:masterfrom
mravn-google merged 4 commits intoflutter:masterfrom
Conversation
Contributor
|
RSLGTM. Would be great to have tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of some corner cases of channel communication, mostly dealing with the JSON code (handling null entries and handling the lack of support for serializing top-level simple values on iOS).
Encoding/decoding errors are now treated as programming errors on Android as well as on iOS. Dart side follows suite in a companion PR on flutter/flutter (flutter/flutter#9621).
These changes make a new flutter+engine integration test suite run (reference TBD).