Fix filter null exceptions#36575
Conversation
|
Gold has detected about 1 new digest(s) on patchset 5. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
auto label is removed for flutter/engine, pr: 36575, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 36575, due to Validations Fail. |
|
Gold has detected about 1 new digest(s) on patchset 6. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Gold has detected about 1 new digest(s) on patchset 7. |
two issues fixed for canvaskit:
fixed by returning the identity matrix in both cases. Mimics NOP behavior, where the filter does nothing.
This is a temporary fix. Will create a better performing fix to handle the above listed edge cases so that we don't have to do the extra work of returning the identity matrix
see flutter/flutter#89433
Pre-launch Checklist
writing and running engine tests.
///).