Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: the output is the test 😅 |
|
Something seems to have gone wrong with the linux license luci check, but doesn't look like it's coming from the tool, or at least the regex in question seems to general and the error message doesn't appear in the engine repo. Guessing maybe something in the infra itself? |
9d6d62f to
594e8e4
Compare
|
auto label is removed for flutter/engine, pr: 36577, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/engine, pr: 36577, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This will make the license script easier to refactor because the license bodies are stable across refactors whereas the metadata about each license is not.
594e8e4 to
265833b
Compare
This will make the license script easier to refactor because the license bodies are stable across refactors whereas the metadata about each license is not.