Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Sort licenses by body#36577

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Hixie:reorder_licenses
Oct 5, 2022
Merged

Sort licenses by body#36577
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Hixie:reorder_licenses

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Oct 3, 2022

This will make the license script easier to refactor because the license bodies are stable across refactors whereas the metadata about each license is not.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor Author

Hixie commented Oct 3, 2022

test-exempt: the output is the test 😅

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with an optional nit.

@cbracken
Copy link
Member

cbracken commented Oct 4, 2022

Something seems to have gone wrong with the linux license luci check, but doesn't look like it's coming from the tool, or at least the regex in question seems to general and the error message doesn't appear in the engine repo. Guessing maybe something in the infra itself?

An error occurred:
code: 3 (INVALID_ARGUMENT) desc: bad request: builder: builder must match "^[a-zA-Z0-9\\-_.\\(\\) ]{1,128}$"

@Hixie Hixie force-pushed the reorder_licenses branch from 9d6d62f to 594e8e4 Compare October 5, 2022 07:05
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 5, 2022

auto label is removed for flutter/engine, pr: 36577, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 5, 2022

auto label is removed for flutter/engine, pr: 36577, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
This will make the license script easier to refactor because the license bodies are stable across refactors whereas the metadata about each license is not.
@Hixie Hixie force-pushed the reorder_licenses branch from 594e8e4 to 265833b Compare October 5, 2022 07:52
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@auto-submit auto-submit bot merged commit 6232980 into flutter:main Oct 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants