This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Stop compiling iOS with bitcode#36596
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Oct 4, 2022
Merged
Conversation
jmagman
force-pushed
the
remove-bitcode
branch
from
d59177d to
332b965
Compare
jmagman
force-pushed
the
remove-bitcode
branch
from
6f5bcbe to
8959dc0
Compare
jmagman
commented
Oct 4, 2022
| "os=Mac-12" | ||
| ], | ||
| "gn": [ | ||
| "--bitcode", |
Member
Author
There was a problem hiding this comment.
v1 recipe change at https://flutter-review.googlesource.com/c/recipes/+/34583
zanderso
approved these changes
Oct 4, 2022
This was referenced Oct 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
--bitcodeflags without removing them, until recipe can be updated. This does not cover removing thestrip_bitcodelogic #36510.https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20Engine%20Release/628
Flutter projects no longer build with bitcode: flutter/flutter#111776 and flutter/flutter#107883
Part of flutter/flutter#107884
Recipe side at https://flutter-review.googlesource.com/c/recipes/+/34583
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.