This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove trailing json comma in mac_ios_engine_profile.json#36604
Merged
jmagman merged 1 commit intoflutter:mainfrom Oct 4, 2022
Merged
Remove trailing json comma in mac_ios_engine_profile.json#36604jmagman merged 1 commit intoflutter:mainfrom
jmagman merged 1 commit intoflutter:mainfrom
Conversation
godofredoc
approved these changes
Oct 4, 2022
Contributor
godofredoc
left a comment
There was a problem hiding this comment.
Should we move engine v2 ios builders to prod to identify issues on presubmit?
Member
Author
If you think it's ready, up to you. |
zanderso
approved these changes
Oct 4, 2022
Contributor
|
auto label is removed for flutter/engine, pr: 36604, due to - The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo in json from #36596 for v2 recipes not running in PRs.
https://ci.chromium.org/p/flutter/builders/staging/Mac%20mac_ios_engine_profile/6682
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.