Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[Windows] Move to Visual Studio 2019"#36606

Merged
auto-submit[bot] merged 1 commit intomainfrom
revert-36538-vs2019
Oct 5, 2022
Merged

Revert "[Windows] Move to Visual Studio 2019"#36606
auto-submit[bot] merged 1 commit intomainfrom
revert-36538-vs2019

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Oct 4, 2022 •
edited by ricardoamador
Loading

Reverts #36538
as it appears to have broken the tree: https://discord.com/channels/608014603317936148/613398423093116959/1026995839278792754

Failure:

  1. https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20platform_channel_sample_test_windows/1804/overview
  2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8801195816777587809/+/u/run_platform_channel_sample_test_windows/test_stdout
Logs... 
[platform_channel_sample_test_windows] [STDOUT] stdout: [ +127 ms] executing: C:\b\s\w\ir\x\w\recipe_cleanup\tmpr1awka7t\flutter sdk\bin\cache\dart-sdk\bin\dart.exe C:\b\s\w\ir\x\w\recipe_cleanup\tmpr1awka7t\flutter sdk\examples\platform_channel\test_driver\button_tap_test.dart -rexpanded
[platform_channel_sample_test_windows] [STDOUT] stdout: [+3014 ms] 00:00 �[32m+0�[0m: button tap test (setUpAll)�[0m
[platform_channel_sample_test_windows] [STDOUT] stderr: [  +31 ms] VMServiceFlutterDriver: Connecting to Flutter application at http://127.0.0.1:52673/c6-w7zT5-Qw=/
[platform_channel_sample_test_windows] [STDOUT] stderr: [ +179 ms] VMServiceFlutterDriver: Isolate found with number: 3990082986865311
[platform_channel_sample_test_windows] [STDOUT] stderr: [  +50 ms] VMServiceFlutterDriver: Isolate is paused at start.
[platform_channel_sample_test_windows] [STDOUT] stderr: [        ] VMServiceFlutterDriver: Attempting to resume isolate
[platform_channel_sample_test_windows] [STDOUT] stdout: [+1207 ms] 00:01 �[32m+0�[0m�[31m -1�[0m: button tap test (setUpAll) �[1m�[31m[E]�[0m�[0m
[platform_channel_sample_test_windows] [STDOUT] stdout: [   +2 ms]   DriverError: Failed to fulfill GetHealth due to remote error
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   Original error: ext.flutter.driver: (112) Service has disappeared
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   Original stack trace:
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #0      new _OutstandingRequest (package:vm_service/src/vm_service.dart:1746:45)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #1      VmService._call (package:vm_service/src/vm_service.dart:2262:21)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #2      VmService.callServiceExtension (package:vm_service/src/vm_service.dart:2233:14)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #3      VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:306:66)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #4      FlutterDriver.checkHealth (package:flutter_driver/src/driver/driver.dart:197:34)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #5      VMServiceFlutterDriver.connect (package:flutter_driver/src/driver/vmservice_driver.dart:229:40)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #6      main.<anonymous closure>.<anonymous closure> (file:///C:/b/s/w/ir/x/w/recipe_cleanup/tmpr1awka7t/flutter%20sdk/examples/platform_channel/test_driver/button_tap_test.dart:13:16)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   #7      _CustomZone.bindUnaryCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1253:12)
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stdout: [  +14 ms]   package:flutter_driver/src/driver/vmservice_driver.dart 318:7   VMServiceFlutterDriver.sendCommand
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:flutter_driver/src/driver/driver.dart 197:28            FlutterDriver.checkHealth
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:flutter_driver/src/driver/vmservice_driver.dart 229:27  VMServiceFlutterDriver.connect
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   test_driver\button_tap_test.dart 13:16                          main.<fn>.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   ===== asynchronous gap ===========================
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1253:12                                    _CustomZone.bindUnaryCallbackGuarded.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [  +10 ms] 00:01 �[32m+0�[0m�[31m -1�[0m: button tap test (tearDownAll)�[0m
[platform_channel_sample_test_windows] [STDOUT] stdout: [   +3 ms] 00:01 �[32m+0�[0m�[31m -2�[0m: button tap test (tearDownAll) �[1m�[31m[E]�[0m�[0m
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   LateInitializationError: Local 'driver' has not been initialized.
[platform_channel_sample_test_windows] [STDOUT] stdout: [   +3 ms]   dart:_internal-patch/internal_patch.dart 209:5     LateError._throwLocalNotInitialized
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   test_driver\button_tap_test.dart 17:7              main.<fn>.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/future.dart 302:31                      new Future.sync
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 236:18   Invoker.runTearDowns.<fn>.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 257:15   Invoker._waitForOutstandingCallbacks.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1398:13                       _rootRun
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1300:19                       _CustomZone.run
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1803:10                       _runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1746:10                       runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 254:5    Invoker._waitForOutstandingCallbacks
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 235:9    Invoker.runTearDowns.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1398:13                       _rootRun
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1300:19                       _CustomZone.run
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1803:10                       _runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1746:10                       runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 230:12   Invoker.runTearDowns
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 378:46  Declarer._tearDownAll.<fn>.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1398:13                       _rootRun
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1300:19                       _CustomZone.run
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1803:10                       _runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1746:10                       runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/declarer.dart 378:14  Declarer._tearDownAll.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 257:15   Invoker._waitForOutstandingCallbacks.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1398:13                       _rootRun
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1300:19                       _CustomZone.run
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1803:10                       _runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   dart:async/zone.dart 1746:10                       runZoned
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 254:5    Invoker._waitForOutstandingCallbacks
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ]   package:test_api/src/backend/invoker.dart 391:17   Invoker._onRun.<fn>.<fn>.<fn>
[platform_channel_sample_test_windows] [STDOUT] stdout: [  +11 ms] 00:01 �[32m+0�[0m�[31m -2�[0m: �[31mSome tests failed.�[0m
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ] Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ] For example, 'dart test --chain-stack-traces'.
[platform_channel_sample_test_windows] [STDOUT] stderr: [   +1 ms] Unhandled exception:
[platform_channel_sample_test_windows] [STDOUT] stderr: [        ] Dummy exception to set exit code.
[platform_channel_sample_test_windows] [STDOUT] stdout: [+1044 ms] "flutter drive" took 22,339ms.
[platform_channel_sample_test_windows] [STDOUT] stderr: [   +6 ms] 
[platform_channel_sample_test_windows] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
[platform_channel_sample_test_windows] [STDOUT] stderr:            #1      DriveCommand.runCommand (package:flutter_tools/src/commands/drive.dart:304:9)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1244:27)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #4      CommandRunner.runCommand (package:args/command_runner.dart:209:13)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:283:9)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:9)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr:            #10     main (package:flutter_tools/executable.dart:91:3)
[platform_channel_sample_test_windows] [STDOUT] stderr:            <asynchronous suspension>
[platform_channel_sample_test_windows] [STDOUT] stderr: 
[platform_channel_sample_test_windows] [STDOUT] stderr: 
[platform_channel_sample_test_windows] [STDOUT] stdout: [   +1 ms] ensureAnalyticsSent: 0ms
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ] Running 0 shutdown hooks
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ] Shutdown hooks complete
[platform_channel_sample_test_windows] [STDOUT] stdout: [        ] exiting with code 1
[platform_channel_sample_test_windows] [STDOUT] Checking for reboot
[platform_channel_sample_test_windows] Process terminated with exit code 0.

@loic-sharma loic-sharma requested a review from zanderso October 4, 2022 23:37
@loic-sharma loic-sharma added the revert Label used to revert changes in a closed and merged pull request. label Oct 5, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 5, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 5, 2022
@ricardoamador ricardoamador added the revert Label used to revert changes in a closed and merged pull request. label Oct 5, 2022
@auto-submit auto-submit bot merged commit cef7219 into main Oct 5, 2022
@auto-submit auto-submit bot mentioned this pull request Oct 5, 2022
Closed
@loic-sharma loic-sharma mentioned this pull request Oct 5, 2022
Merged
8 tasks
loic-sharma added a commit to flutter/flutter that referenced this pull request Oct 5, 2022
@loic-sharma
Manually roll Flutter Engine from cbb9d0b06 to cef7219 (#112895)
76dd29f 
flutter/engine@37d8342...cef7219

* Revert "[Windows] Move to Visual Studio 2019" (flutter/engine#36606)

Issue: #112894
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
cef7219 Revert "[Windows] Move to Visual Studio 2019" (flutter/engine…
23cb325 
…#36606)
@loic-sharma loic-sharma mentioned this pull request Oct 5, 2022
Merged
@cbracken cbracken deleted the revert-36538-vs2019 branch October 5, 2022 20:41
loic-sharma added a commit to flutter/buildroot that referenced this pull request Oct 5, 2022
@loic-sharma
Revert "[Windows] Move to Visual Studio 2019" (#635)
6c65790 
Reverts #632

After #632, the buildroot cannot be rolled to the engine without the corresponding changes in flutter/engine#36606. However, flutter/engine#36606 was reverted as it broke the Flutter tree. This reverts #632 to allow buildroot to engine rolls while I figure out the bug that broke the tree.

Revert issue: flutter/flutter#112894
@loic-sharma loic-sharma mentioned this pull request Oct 25, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-windows revert Label used to revert changes in a closed and merged pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loic-sharma @zanderso @fluttergithubbot @ricardoamador