This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove pendown trick for solid strokes#36611
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Oct 5, 2022
Merged
[Impeller] Remove pendown trick for solid strokes#36611auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove special "pen down" attribute from the solid generator algorithm. The triangle created between contours already has zero area. We already rely on zero area triangles getting discarded by the rasterizer for the overdraw prevention technique we use.
Part of preparing solid strokes for the deferred geometry refactor. See also https://flutter.dev/go/impeller-geometry#heading=h.fymtgh4bhdl2 for a detailed explanation.