Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[Impeller] Use fast path for CPU generated textures where possible"#36622

Merged
auto-submit[bot] merged 1 commit intomainfrom
revert-36466-cheap_texture
Oct 5, 2022
Merged

Revert "[Impeller] Use fast path for CPU generated textures where possible"#36622
auto-submit[bot] merged 1 commit intomainfrom
revert-36466-cheap_texture

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 5, 2022

Reverts #36466

Probably caused simulator problems discussed in b/249121691

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 5, 2022

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield added autosubmit Merge PR when tree becomes green via auto submit App and removed e: impeller labels Oct 5, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 5, 2022

auto label is removed for flutter/engine, pr: 36622, due to - The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Oct 5, 2022

Windows failure looks like a flake in impellerc...

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022
@auto-submit auto-submit bot merged commit c2aa65b into main Oct 5, 2022
@dnfield dnfield deleted the revert-36466-cheap_texture branch October 5, 2022 19:50
@dnfield dnfield self-assigned this Oct 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants