[Impeller] Switch SolidStrokeContents to use solid fill shaders; remove solid stroke shaders#36624
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
|
I don't know if these tasks are going to finish . If you push an empty commit, that should unclog it... |
bdero
force-pushed
the
bdero/remove-solid-stroke-shaders
branch
from
dbe13cb to
df956fa
Compare
|
Whoops, thanks. This fell off my radar. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 36624, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
force-pushed
the
bdero/remove-solid-stroke-shaders
branch
from
df956fa to
f8cfd6f
Compare
…rs; remove solid stroke shaders (flutter/engine#36624)
3 participants
This is another step towards removing the special sauce from solid stroke rendering. See also: https://flutter.dev/go/impeller-geometry#heading=h.fymtgh4bhdl2