This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS][iOS] Eliminate strip_bitcode action#36627
Merged
cbracken merged 1 commit intoflutter:mainfrom Oct 5, 2022
cbracken:farewell-strip-bitcode
Merged
[macOS][iOS] Eliminate strip_bitcode action#36627cbracken merged 1 commit intoflutter:mainfrom cbracken:farewell-strip-bitcode
cbracken merged 1 commit intoflutter:mainfrom
cbracken:farewell-strip-bitcode
Conversation
Eliminates the `strip_bitcode` GN rule defined in //flutter/sky/tools/mac.gni and the related script at //flutter/sky/tools/strip_bitcode.py. As of Xcode 14, bitcode is deprecated, no longer enabled by default, and generates a warning message if a project enables it. Bitcode support will be removed entirely from a future version of Xcode. The `strip_bitcode` rule had two purposes: 1. Copy the binary specified by its input parameter to the path specified by its output parameter. 2. Strip bitcode segments as it does so. While we no longer require the second of these functions, we still use the first to create a `gen_snapshot` binary suffixed with the target architecture. This replaces `strip_bitcode` with the built-in gn `copy` rule instead. Issue: flutter/flutter#107884 Issue: flutter/flutter#112896 Issue: flutter/flutter#101138 Issue: flutter/flutter#103386
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates the
strip_bitcodeGN rule defined in//flutter/sky/tools/mac.gni and the related script at //flutter/sky/tools/strip_bitcode.py.
As of Xcode 14, bitcode is deprecated, no longer enabled by default, and generates a warning message if a project enables it. Bitcode support will be removed entirely from a future version of Xcode.
The
strip_bitcoderule had two purposes:While we no longer require the second of these functions, we still use the first to create a
gen_snapshotbinary suffixed with the target architecture. This replacesstrip_bitcodewith the built-in gncopyrule instead.Issue: flutter/flutter#107884
Issue: flutter/flutter#112896
Issue: flutter/flutter#101138
Issue: flutter/flutter#103386
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.