This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] Eliminate framework bitcode stripping flag#36628
Merged
cbracken merged 1 commit intoflutter:mainfrom Oct 6, 2022
cbracken:goodbye-strip-bitcode-option
Merged
[iOS] Eliminate framework bitcode stripping flag#36628cbracken merged 1 commit intoflutter:mainfrom cbracken:goodbye-strip-bitcode-option
cbracken merged 1 commit intoflutter:mainfrom
cbracken:goodbye-strip-bitcode-option
Conversation
Member
Author
|
If iOS is still using the v1 recipes, we'll need to patch those first. |
Member
https://flutter-review.googlesource.com/c/recipes/+/34583 removed usage and just merged |
jmagman
approved these changes
Oct 5, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM, if the release build fails you may need to re-run to pick up the recipe change.
Eliminates the `--strip-bitcode` flag from the `create_ios_framework.py` and `create_full_ios_framework.py` scripts. Issue: flutter/flutter#107884
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates the
--strip-bitcodeflag from thecreate_ios_framework.pyandcreate_full_ios_framework.pyscripts.Issue: flutter/flutter#107884
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.