Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Skia from ec4cb06b851d to 79fd56ba7ff7 (23 revisions)#36639

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
skia-flutter-autoroll:skia-flutter-autoroll-f73cc9a3-5b5a-4335-98be-4583665698f9-1665066689
Oct 6, 2022
Merged

Roll Skia from ec4cb06b851d to 79fd56ba7ff7 (23 revisions)#36639
auto-submit[bot] merged 1 commit intoflutter:mainfrom
skia-flutter-autoroll:skia-flutter-autoroll-f73cc9a3-5b5a-4335-98be-4583665698f9-1665066689

Conversation

@skia-flutter-autoroll
Copy link
Contributor

https://skia.googlesource.com/skia.git/+log/ec4cb06b851d..79fd56ba7ff7

2022-10-06 [email protected] Cleanup constructors for SkTDArray
2022-10-06 [email protected] Roll ANGLE from 637209c912cc to 13195f8a9000 (16 revisions)
2022-10-06 [email protected] Roll SwiftShader from 3d7faaa40575 to 2b155acd6a90 (3 revisions)
2022-10-06 [email protected] Roll Dawn from 8800d885e765 to 3a7c6bd59525 (11 revisions)
2022-10-06 [email protected] Roll vulkan-deps from 5d66d3e5917b to 77b69159532a (8 revisions)
2022-10-05 [email protected] Change SkTHashTable::Slot from a struct to a class.
2022-10-05 [email protected] Allow sk_Caps usage from Runtime Effect modules.
2022-10-05 [email protected] Improve Setting node IR creation.
2022-10-05 [email protected] Fix simplified emboldened glyphs
2022-10-05 [email protected] Remove guard protecting free in sk_free
2022-10-05 [email protected] Reland "Narrow usage of GrGpu::didWriteToSurface in GL backend"
2022-10-05 [email protected] Eliminate parameter names in function prototypes.
2022-10-05 [email protected] Revert "[bazel] Add individual test targets, broken up by CPU and GPU"
2022-10-05 [email protected] RectanizerSkyline: optimize reset
2022-10-05 [email protected] [graphite] Instantiate in CopyTextureToBufferTask::prepareResources.
2022-10-05 [email protected] [bazel] Add individual test targets, broken up by CPU and GPU
2022-10-05 [email protected] SkTArray: more mem-movable types
2022-10-05 [email protected] Improve string-to-float roundtrip checking.
2022-10-05 [email protected] Cleanup casting for SkTDArray
2022-10-05 [email protected] Roll vulkan-deps from e009633d2013 to 5d66d3e5917b (2 revisions)
2022-10-05 [email protected] Rename skgpu::v1 -> skgpu::ganesh in some Ganesh ops (ed. 2)
2022-10-05 [email protected] Roll ANGLE from 5d7c4eca9bf2 to 637209c912cc (9 revisions)
2022-10-05 [email protected] Roll Dawn from 0c2909e4d4c8 to 8800d885e765 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/ec4cb06b851d..79fd56ba7ff7

2022-10-06 [email protected] Cleanup constructors for SkTDArray
2022-10-06 [email protected] Roll ANGLE from 637209c912cc to 13195f8a9000 (16 revisions)
2022-10-06 [email protected] Roll SwiftShader from 3d7faaa40575 to 2b155acd6a90 (3 revisions)
2022-10-06 [email protected] Roll Dawn from 8800d885e765 to 3a7c6bd59525 (11 revisions)
2022-10-06 [email protected] Roll vulkan-deps from 5d66d3e5917b to 77b69159532a (8 revisions)
2022-10-05 [email protected] Change SkTHashTable::Slot from a struct to a class.
2022-10-05 [email protected] Allow sk_Caps usage from Runtime Effect modules.
2022-10-05 [email protected] Improve Setting node IR creation.
2022-10-05 [email protected] Fix simplified emboldened glyphs
2022-10-05 [email protected] Remove guard protecting free in sk_free
2022-10-05 [email protected] Reland "Narrow usage of GrGpu::didWriteToSurface in GL backend"
2022-10-05 [email protected] Eliminate parameter names in function prototypes.
2022-10-05 [email protected] Revert "[bazel] Add individual test targets, broken up by CPU and GPU"
2022-10-05 [email protected] RectanizerSkyline: optimize reset
2022-10-05 [email protected] [graphite] Instantiate in CopyTextureToBufferTask::prepareResources.
2022-10-05 [email protected] [bazel] Add individual test targets, broken up by CPU and GPU
2022-10-05 [email protected] SkTArray: more mem-movable types
2022-10-05 [email protected] Improve string-to-float roundtrip checking.
2022-10-05 [email protected] Cleanup casting for SkTDArray
2022-10-05 [email protected] Roll vulkan-deps from e009633d2013 to 5d66d3e5917b (2 revisions)
2022-10-05 [email protected] Rename skgpu::v1 -> skgpu::ganesh in some Ganesh ops (ed. 2)
2022-10-05 [email protected] Roll ANGLE from 5d7c4eca9bf2 to 637209c912cc (9 revisions)
2022-10-05 [email protected] Roll Dawn from 0c2909e4d4c8 to 8800d885e765 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2022
@skia-flutter-autoroll skia-flutter-autoroll force-pushed the skia-flutter-autoroll-f73cc9a3-5b5a-4335-98be-4583665698f9-1665066689 branch from 981f089 to a442570 Compare October 6, 2022 14:31
@zanderso
Copy link
Member

zanderso commented Oct 6, 2022

@godofredoc Do you know why the bot_update step on one of the mac_host_engine shards took nearly 50 minutes? https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/4135/overview

@zanderso
Copy link
Member

zanderso commented Oct 6, 2022

Oh, now the main shard is also taking >30 minutes on bot_update so the whole presubmit check will take >90 minutes: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_host_engine/183/overview

@godofredoc
Copy link
Contributor

Oh, now the main shard is also taking >30 minutes on bot_update so the whole presubmit check will take >90 minutes: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_host_engine/183/overview

This is most likely a problem with the build source code caches in recipes v2 + a problem with the checkout logic forcing full checkouts in the 50th%

@auto-submit auto-submit bot merged commit 966f249 into flutter:main Oct 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 6, 2022
@skia-flutter-autoroll skia-flutter-autoroll deleted the skia-flutter-autoroll-f73cc9a3-5b5a-4335-98be-4583665698f9-1665066689 branch October 13, 2022 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants