[Impeller] Wire image sampler descriptors for Vulkan#36641
[Impeller] Wire image sampler descriptors for Vulkan#36641iskakaushik merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| return nullptr; | ||
| } | ||
|
|
||
| vk::ImageViewCreateInfo view_create_info = {}; |
There was a problem hiding this comment.
Thinking out aloud: Perhaps we should have a convention for these FooCreateInfo structs? Something like FooCreateInfo foo_desc; auto foo = device.createFoo(foo_desc)? Here, view_create_info is somewhat misleading as you are creating an image_view and the create_info bit is redundant.
Just nits.
There was a problem hiding this comment.
agreed, I will do a follow-up refactor to fix all these instances.
2 participants
No description provided.