Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move mac_host_engine to bringup.#36647

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:mac_host_engine_back
Oct 6, 2022
Merged

Move mac_host_engine to bringup.#36647
auto-submit[bot] merged 1 commit intoflutter:mainfrom
godofredoc:mac_host_engine_back

Conversation

@godofredoc
Copy link
Contributor

There were three different issues identified as when running this build in prod. We are moving it back to staging while we fix the issues to prevent impacting the tree greeness.

Bug: flutter/flutter#113068
Bug: flutter/flutter#113066
Bug: flutter/flutter#113065

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

There were three different issues identified as when running this
build in prod. We are moving it back to staging while we fix the issues
to prevent impacting the tree greeness.

Bug: flutter/flutter#113068
Bug: flutter/flutter#113066
Bug: flutter/flutter#113065
@godofredoc godofredoc requested a review from zanderso October 6, 2022 21:34
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2022
@auto-submit auto-submit bot merged commit f54650f into flutter:main Oct 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2022
@godofredoc godofredoc deleted the mac_host_engine_back branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants