This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Do SourceOver alpha compositing for advanced blends; write results to the pass with kSource#36658
Merged
bdero merged 2 commits intoflutter:mainfrom Oct 8, 2022
Merged
Conversation
Contributor
Author
|
Verified that this doesn't regress gskinnerTeam/flutter-wonderous-app#34.
|
zanderso
reviewed
Oct 7, 2022
|
|
||
| frag_color = vec4(blended, 1) * src.a * dst.a; | ||
| frag_color = mix(dst_sample, blended, src.a); | ||
| //frag_color = dst_sample; |
Contributor
|
You'll need to pull latest to get the framework tests to compile |
jonahwilliams
approved these changes
Oct 7, 2022
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM (with Zach's nit fixed)
a0e93c8 to
75091a7
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2022
…s; write results to the pass with kSource (flutter/engine#36658)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#110672.
This fixes the major issue found in #36656:
Jonah's test app (left is Skia, right is Impeller):
2 remaining issues: