Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Apply path effects from a DlPaint to a DisplayListBuilder#36669

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:dl_paint_path_effect
Oct 10, 2022
Merged

Apply path effects from a DlPaint to a DisplayListBuilder#36669
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:dl_paint_path_effect

Conversation

@jason-simmons
Copy link
Member

No description provided.

@jason-simmons jason-simmons requested a review from flar October 7, 2022 22:06
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2022
@auto-submit auto-submit bot merged commit 623d2d9 into flutter:main Oct 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants