This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Use root-ssl-certificates in v2 runner manifests#36703
Merged
akbiggs merged 1 commit intoflutter:mainfrom Oct 11, 2022
ypomortsev:ssl-certs
Merged
[fuchsia] Use root-ssl-certificates in v2 runner manifests#36703akbiggs merged 1 commit intoflutter:mainfrom ypomortsev:ssl-certs
akbiggs merged 1 commit intoflutter:mainfrom
ypomortsev:ssl-certs
Conversation
* Add a `use` for the `root-ssl-certificates` to ensure BoringSSL
can read the certificates at /config/ssl
* Reformat manifest with `cmc format`
Fixes `HandshakeException`s when establishing a secure connection:
```
HandshakeException: Handshake error in client (OS Error:
CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(handshake.cc:393))
<asynchronous suspension>
```
Depends on changes that offer this directory to the runners,
e.g. https://fxrev.dev/737597
Bug: https://fxbug.dev/111712
Contributor
Author
|
@akbiggs PTAL! |
akbiggs
approved these changes
Oct 10, 2022
akbiggs
added
autosubmit
Contributor
|
LGTM. Repo policy is that we need two Flutter org approvers on each CL that's from a non-Flutter org member, so we'll need @lin-erik's approval before adding the autosubmit label and merging. |
lin-erik
approved these changes
Oct 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usefor theroot-ssl-certificatesto ensure BoringSSL can read the certificates at /config/sslcmc formatFixes
HandshakeExceptions when establishing a secure connection:Depends on changes that offer this directory to the runners, e.g. https://fxrev.dev/737597
Bug: https://fxbug.dev/111712