This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] Implement RuntimeEffectContents"#36883
Merged
Conversation
This reverts commit d079196.
bdero
approved these changes
Oct 20, 2022
Contributor
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
Whoops, this was due to merge ordering.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2022
* 7d18d70 [Impeller] Support external textures on iOS (flutter/engine#36498) * d079196 [Impeller] Implement RuntimeEffectContents (flutter/engine#36866) * 119e839 Revert "[Impeller] Implement RuntimeEffectContents (#36866)" (flutter/engine#36883) * bcd83df [Impeller] Reland RuntimeEffectContents (flutter/engine#36884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #36866
Tree breakage. One example: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Android%20AOT%20Engine/18743/overview