This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add necessary #includes for SkCodecAnimation.h#37040
Merged
jason-simmons merged 1 commit intoflutter:mainfrom Oct 26, 2022
Merged
Add necessary #includes for SkCodecAnimation.h#37040jason-simmons merged 1 commit intoflutter:mainfrom
jason-simmons merged 1 commit intoflutter:mainfrom
Conversation
jason-simmons
approved these changes
Oct 26, 2022
jason-simmons
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 37040, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
Contributor
|
auto label is removed for flutter/engine, pr: 37040, due to Validations Fail. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Skia team is cleaning up the #includes inside our public headers. These changes keep Flutter Engine from depending on transitive dependencies that are being removed.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].