This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Prevent (forced-colors: active) from making the invisible text fields visible#37089
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Nov 1, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
platform-web
yjbanov
approved these changes
Oct 27, 2022
Contributor
|
My only question is around the context of invisible text fields. What is the use case and why we're setting everything to |
Contributor
Author
|
@nbayati The framework is responsible for "drawing" the text field and its contents. But on the web, we still need a real element on the page (to show the virtual keyboard on mobile, and to listen to change events, etc). We make the element that we inject into the page transparent so that it doesn't affect what flutter draws. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2022
…le text fields visible (flutter/engine#37089)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
(forced-colors: active)is enabled in Chrome settings, it messes with the trasnparent styles that we set on text fields. This PR addsforced-color-adjust: none;to prevent that.