This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove usages of deprecated old native "<name>" syntax.#37104
Merged
mkustermann merged 2 commits intoflutter:mainfrom Oct 28, 2022
Merged
Remove usages of deprecated old native "<name>" syntax.#37104mkustermann merged 2 commits intoflutter:mainfrom
native "<name>" syntax.#37104mkustermann merged 2 commits intoflutter:mainfrom
Conversation
…:external-anme', '<name>') instead See dart-lang/sdk#28791
flutter-dashboard
bot
added
embedder
dcharkes
approved these changes
Oct 28, 2022
| bool operator ==(Object other) { | ||
| return other is Handle | ||
| && other.handle == handle; | ||
| return other is Handle && |
Member
Author
There was a problem hiding this comment.
Yeah, I changed the code, it autoformatted, then I had to undo the autoformatting by-hand, ...
(Flutter doesn't use dart format for reasons beyond my comprehension)
Contributor
There was a problem hiding this comment.
(Flutter doesn't use
dart formatfor reasons beyond my comprehension)
++
mraleph
approved these changes
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
) The old native "<name>" syntax is being replaced with external functions that have a @pragma("external-name", "<name>"). See dart-lang/sdk#28791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
native "<name>"syntax is being replaced with external functions thathave a
@pragma("external-name", "<name>").See dart-lang/sdk#28791