Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add the Impeller shader lib to the engine archive targets#37218

Merged
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/archive-shader-lib
Nov 1, 2022
Merged

[Impeller] Add the Impeller shader lib to the engine archive targets#37218
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/archive-shader-lib

Conversation

@bdero
Copy link
Contributor

@bdero bdero commented Nov 1, 2022

No description provided.

@bdero bdero requested a review from zanderso November 1, 2022 19:15
@bdero bdero self-assigned this Nov 1, 2022
@bdero
Copy link
Contributor Author

bdero commented Nov 1, 2022 •
edited
Loading

@zanderso I don't really know if this is correct. I assume the reason we only include impellerc when flutter_runtime_mode == "debug" is that we only want to ship the debug version of impellerc? I suspect the correct behavior would be for me to include the shader lib alongside impellerc.

@zanderso
Copy link
Member

zanderso commented Nov 1, 2022

This change is correct. The terminology is a little confusing here. "debug" in this context refers to the Flutter runtime mode, not the runtime mode of the host binaries. The host binaries are compiled with optimizations (and stripped, I think). The host binaries are only archived for "debug" Flutter runtime mode so that we only do it once.

@bdero
Copy link
Contributor Author

bdero commented Nov 1, 2022

Ah, that makes sense. Smoke tested this and the included dir is working as intended:

❯ autoninja -C ../out/host_debug_unopt -j 1000 flutter/build/archives:artifacts
ninja: Entering directory `../out/host_debug_unopt'
[4/4] STAMP obj/flutter/build/archives/artifacts.stamp
❯ unzip ../out/host_debug_unopt/zip_archives/darwin-x64/artifacts.zip -d artifacts
Archive:  ../out/host_debug_unopt/zip_archives/darwin-x64/artifacts.zip
  inflating: artifacts/gen_snapshot
  inflating: artifacts/icudtl.dat
  inflating: artifacts/flutter_tester
  inflating: artifacts/LICENSE.impellerc.md
  inflating: artifacts/LICENSE.path_ops.md
  inflating: artifacts/impellerc
  inflating: artifacts/shader_lib/impeller/constants.glsl
  inflating: artifacts/shader_lib/impeller/color.glsl
  inflating: artifacts/shader_lib/impeller/types.glsl
  inflating: artifacts/shader_lib/impeller/branching.glsl
  inflating: artifacts/shader_lib/impeller/gaussian.glsl
  inflating: artifacts/shader_lib/impeller/blending.glsl
  inflating: artifacts/shader_lib/impeller/transform.glsl
  inflating: artifacts/shader_lib/impeller/texture.glsl
  inflating: artifacts/shader_lib/flutter/runtime_effect.glsl
  inflating: artifacts/libpath_ops.dylib
  inflating: artifacts/libtessellator.dylib
  inflating: artifacts/isolate_snapshot.bin
  inflating: artifacts/vm_isolate_snapshot.bin
  inflating: artifacts/frontend_server.dart.snapshot
  inflating: artifacts/entitlements.txt

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2022
@bdero bdero merged commit 66379f1 into flutter:main Nov 1, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
66379f1 Add the Impeller shader lib to the engine archive (flutter/en…
e88d9d9 
…gine#37218)
@bdero bdero mentioned this pull request Nov 2, 2022
Merged
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@bdero @schwa423
Add the Impeller shader lib to the engine archive (flutter#37218)
a75ccc6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bdero bdero

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdero @zanderso