This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add ability to unregister shaders#37229
Merged
bdero merged 1 commit intoflutter:mainfrom Nov 2, 2022
Merged
Conversation
chinmaygarde
approved these changes
Nov 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFunctionsearches through the libraries to find a matching function if one doesn't exist in the function map, I do the same and delete the library if found. I think we should tighten this up at some point by either back shader keys to specific libraries, or perhaps separateRegisterFunctionlibraries into their own list distinct from those passed in through the ctor.