This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make iOS PlatformView to reuse VisualEffectView when possible.#37263
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom Nov 4, 2022
Merged
Make iOS PlatformView to reuse VisualEffectView when possible.#37263auto-submit[bot] merged 5 commits intoflutter:mainfrom
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
| @@ -168,37 +197,36 @@ - (BOOL)pointInside:(CGPoint)point withEvent:(UIEvent*)event { | |||
| } | |||
|
|
|||
| - (void)applyBlurBackdropFilters:(NSMutableArray<PlatformViewFilter*>*)filters { | |||
Contributor
There was a problem hiding this comment.
Use NSArray instead since you're not mutating it?
| [self addSubview:backdropFilterView]; | ||
| [self.backdropFilterSubviews addObject:backdropFilterView]; | ||
| } else { | ||
| [filter updateVisualEffectView:self.backdropFilterSubviews[index]]; |
Contributor
There was a problem hiding this comment.
Would it be possible to just update the CAFilters instead so you don't have to remove the existing view from its superview?
Contributor
Author
There was a problem hiding this comment.
This is what the code is doing: update the CAFilters and Frame of the existing views.
LongCatIsLooong
approved these changes
Nov 3, 2022
added 3 commits
November 3, 2022 14:04
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
* 49acbfb Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a5 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d40 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755a Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398cc Make hot reload work (flutter/engine#37304) * 69a2753 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…er#37263) * reuse visual effect view is possible * fix double retain * review * rewview * remove unnecessary check
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…4667) * 49acbfb Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a5 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d40 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755a Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398cc Make hot reload work (flutter/engine#37304) * 69a2753 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps visual effect view alive and reuse them when possible.
Fixes flutter/flutter#114443
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.