This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add package:ffi as path dependency to flutter_frontend_server#37802
Merged
mkustermann merged 1 commit intoflutter:mainfrom Nov 21, 2022
Merged
Add package:ffi as path dependency to flutter_frontend_server#37802mkustermann merged 1 commit intoflutter:mainfrom
mkustermann merged 1 commit intoflutter:mainfrom
Conversation
The CL in [0] added package:ffi as dependency to package:compiler. Since flutter_frontend_server needs all dependencies as path dependencies, we need to add package:ffi there via path. [0] https://dart-review.googlesource.com/c/sdk/+/269640
whesse
approved these changes
Nov 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2022
* 913fa02 Roll Fuchsia Mac SDK from VeOzYBpD9mZ9VZXxv... to rApsrzmdh6Pxy9WkO... (flutter/engine#37799) * 46a6b54 Add package:ffi as path dependency to flutter_frontend_server (flutter/engine#37802)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5758) * 913fa02 Roll Fuchsia Mac SDK from VeOzYBpD9mZ9VZXxv... to rApsrzmdh6Pxy9WkO... (flutter/engine#37799) * 46a6b54 Add package:ffi as path dependency to flutter_frontend_server (flutter/engine#37802)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5758) * 913fa02 Roll Fuchsia Mac SDK from VeOzYBpD9mZ9VZXxv... to rApsrzmdh6Pxy9WkO... (flutter/engine#37799) * 46a6b54 Add package:ffi as path dependency to flutter_frontend_server (flutter/engine#37802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CL in [0] added package:ffi as dependency to package:compiler. Since flutter_frontend_server needs all dependencies as path dependencies, we need to add package:ffi there via path.
[0] https://dart-review.googlesource.com/c/sdk/+/269640