[web] Use generic variable name for trusted url#37872
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Good catch! This probably started life inline somewhere, and when I extracted it to a method I forgot to rename that var. Sssship it!
mdebbar
added
the
autosubmit
* 399fca7 [web] Use generic variable name for trusted url (flutter/engine#37872) * acefe5f Vulnerability Scanning on Third Party Deps (flutter/engine#36506) * 8a40e83 Roll Dart SDK from c32f12ffbef2 to a7d1f804fa27 (1 revision) (flutter/engine#37873)
…5952) * 399fca7 [web] Use generic variable name for trusted url (flutter/engine#37872) * acefe5f Vulnerability Scanning on Third Party Deps (flutter/engine#36506) * 8a40e83 Roll Dart SDK from c32f12ffbef2 to a7d1f804fa27 (1 revision) (flutter/engine#37873)
…5952) * 399fca7 [web] Use generic variable name for trusted url (flutter/engine#37872) * acefe5f Vulnerability Scanning on Third Party Deps (flutter/engine#36506) * 8a40e83 Roll Dart SDK from c32f12ffbef2 to a7d1f804fa27 (1 revision) (flutter/engine#37873)
2 participants
I was exploring around this code when I found canvaskit variable names where they shouldn't be.
Rename
trustedCanvasKitUrl=>trustedUrl.