This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Keyboard] Enable special CapsLock handling and key guarding for Web on iOS#37972
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Nov 30, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
platform-web
gspencergoog
approved these changes
Nov 30, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Modulo the suggestion about using a ValueVariant in the test.
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 1, 2022
* a620595 Impl and test (flutter/engine#37972) * 99b000e Roll buildroot to prevent excessive dirtying on Xcode 14 (flutter/engine#37991)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…6310) * a620595 Impl and test (flutter/engine#37972) * 99b000e Roll buildroot to prevent excessive dirtying on Xcode 14 (flutter/engine#37991)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…6310) * a620595 Impl and test (flutter/engine#37972) * 99b000e Roll buildroot to prevent excessive dirtying on Xcode 14 (flutter/engine#37991)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…6310) * a620595 Impl and test (flutter/engine#37972) * 99b000e Roll buildroot to prevent excessive dirtying on Xcode 14 (flutter/engine#37991)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS system has some different rules for keyboard:
Web on macOS already has special rules to handle them.
However, we recently realized that iOS has the same rules. This PR applies these rules to Web on iOS as well.
This PR also fixes a test that incorrectly uses
OperatingSystem.linuxto test key guarding.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.